Messages in this thread | | | Date | Fri, 16 Dec 2011 05:13:58 +0000 (GMT) | From | 함명주 <> | Subject | Re: Re: [PATCH 2/2] misc: add driver support for MAX8997 MUIC |
| |
Samuel Ortiz<sameo@linux.intel.com> wrote: > Hi Arnd, > On Thu, Dec 15, 2011 at 03:34:01PM +0000, Arnd Bergmann wrote: > > On Thursday 15 December 2011, MyungJoo Ham wrote: > > > Arnd Bergmann wrote: > > > > On Monday 12 December 2011, Samuel Ortiz wrote: > > > > The part that is not clear to me is how this new driver fits in > > > > with the first fsa9480 driver and the currently discussed extcon > > > > subsystem, apparently all written by the same team at Samsung. > > > > Is this misc driver still useful when the extcon framework gets > > > > merged? > > > > > > When extcom gets merged, this driver should be updated. It looks like allowing > > > the interrupt handler to update extcon state would be enough. Bascially, this > > > is all this driver is required for extcon to work. (and the prvious author of > > > extcon--"extended" switch class at that time--was the author of this patch.) > > > > > > Anyway, this patch has just told me that I'll need to add more sysfs entries > > > for extcon to show the list of cable names and/or to show the status for each > > > of them, soon or later. > > > > I think it would be better not to merge this driver until the user interface > > in the extcon framework has been finalized. I don't mind the driver, but I > > want to prevent user interfaces from appearing in the kernel that we > > intend to change anyway. > > > > How about dropping the driver from the mfd tree, and adding it into the > > extcon series for the next posting? > Sounds good to me, I'll drop it. > > Cheers, > Samuel. >
To wait for extcon get merged and keep the MAX8997-MUIC without any sysfs interfaces or extcon feature, the following patch has been submitted yesterday:
http://lkml.org/lkml/2011/12/15/123
[PATCH] misc: max8997-muic: remove sysfs attribute > The 'switch' sysfs attribute is used for > showing and setting the switch state of the device. > However, setting it from the userspace focibly is not appropriate. > And showing the state can be handled from > other places (e.g. external connector) in a unified manner. > This patch removes the sysfs attribute. > Plus, uevent messages for interrupts are also removed. > > The initial max8997-muic driver is merged at: > git://git.kernel.org/pub/scm/linux/kernel/git/sameo/mfd-2.6.git for-next > > Signed-off-by: Donggeun Kim <dg77.kim@samsung.com> > Signed-off-by: MyungJoo Ham <myungjoo.ham@samsung.com> > Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com> > Acked-by: Greg Kroah-Hartman <gregkh@suse.de>
We can send the patch (with extcon support) later anyway if it's going to be dropped for now.
And, this MAX8997-MUIC will be the example driver for extcon located at /drivers/extcon/.
Cheers! MyungJoo. | |