lkml.org 
[lkml]   [2011]   [Dec]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: unexpected taint message
From
Date
On Fri, 2011-12-16 at 08:49 -0600, Larry Finger wrote:

> > + switch (flag) {
> > + case TAINT_CRAP:
> > + case TAINT_WARN:
> > + case TAINT_OOT_MODULE:
> > + break;
> > + default:
> > + if (__debug_locks_off())
> > + printk(KERN_WARNING
> > + "Disabling lock debugging due to kernel taint\n");
> > + }
> >
> > set_bit(flag,&tainted_mask);
> > }
>
> Yes. I like this patch a lot. Unfortunately, VirtualBox was a part of the
> decision to add the OOT taint. At least for that reason, this patch would not be
> accepted upstream. It is too bad that the Oracle people fought so hard to keep
> their module from setting TAINT_CRAP the way that GregKH wanted. That would have
> had fewer side effects for me.

I'm not sure -- I mean, it's one thing to identify OOT modules and
refuse to support them (and ignore lockdep reports with OOT set), but
it's another to just disable lockdep? I think?

johannes



\
 
 \ /
  Last update: 2011-12-16 15:53    [from the cache]
©2003-2011 Jasper Spaans