lkml.org 
[lkml]   [2011]   [Dec]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch] sgi-xp: nested calls to spin_lock_irqsave()
On Thu, Dec 15, 2011 at 09:48:05AM +0300, Dan Carpenter wrote:
> The code here has a nested spin_lock_irqsave(). It's not needed since
> IRQs are already disabled and it causes a problem because it means that
> IRQs won't be enabled again at the end. The second call to
> spin_lock_irqsave() will overwrite the value of irq_flags and we can't
> restore the proper settings.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Acked-by: Robin Holt <holt@sgi.com>


\
 
 \ /
  Last update: 2011-12-16 12:57    [W:0.032 / U:0.304 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site