lkml.org 
[lkml]   [2011]   [Dec]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] asus-wmi: explicitly set the wireless LED
From
On Thu, Dec 15, 2011 at 9:22 AM, Johannes Berg
<johannes@sipsolutions.net> wrote:
> On Thu, 2011-12-15 at 08:07 +0100, Corentin Chary wrote:
>
>> Anyway, you should use a led trigger for that, ideally the rfkill%d
>> led trigger, but for that you need the rfkill idx, which is not
>> exported, so you may need a new rfkill_idx() function. CCing rfkill
>> and led guys, they may have a better advice on that.
>
> Since you wouldn't want to build the string yourself, you'd probably
> want a new rfkill_ledtrigname() function like this:
>
> static const char *rfkill_ledtrigname(struct rfkill *rfkill)
> {
> #ifdef CONFIG_RFKILL_LEDS
>        return rfkill->ledtrigname;
> #endif
>        return NULL;
> }
>
> which you use to assign the LED class device's default trigger.
>
> johannes
>

Right, but is rfkill->ledtrigname really set somewhere ?

rfkill->led_trigger.name seems safer to use.


--
Corentin Chary
http://xf.iksaif.net
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2011-12-15 09:27    [W:2.470 / U:0.436 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site