Messages in this thread | | | Date | Thu, 15 Dec 2011 15:11:03 -0800 | From | Greg KH <> | Subject | Re: [PATCH] usb: musb: fix pm_runtime mismatch |
| |
On Thu, Dec 15, 2011 at 03:02:25PM -0800, Greg KH wrote: > On Fri, Dec 16, 2011 at 12:42:14AM +0200, Felipe Contreras wrote: > > In musb_init_controller() there's a pm_runtime_put(), but there's no > > pm_runtime_get(), which creates a mismatch that causes the driver to > > sleep when it shouldn't. > > > > This was introduced in 7acc619, but it wasn't triggered until 18a2689 > > was merged to Linus' branch at point 6899608. > > > > However, it seems most of the time this is used in a way that keeps the > > counter above 0, so nobody noticed. Also, it seems to depend on the > > configuration used. > > > > I found the problem by loading isp1704_charger before any usb gadgets: > > http://article.gmane.org/gmane.linux.kernel/1226122 > > > > All versions after 2.6.39 are affected. > > > > Cc: stable@vger.kernel.org > > Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com> > > --- > > drivers/usb/musb/musb_core.c | 2 -- > > 1 files changed, 0 insertions(+), 2 deletions(-) > > Will you be including this in your next pull request for me to include > in my tree to go to Linus soon?
Doh, wrong Felipe, my apologies.
greg k-h
| |