Messages in this thread | | | From | Grant Likely <> | Date | Wed, 14 Dec 2011 14:41:01 -0700 | Subject | Re: [RFC PATCH v2 1/4] dt: add of_get_child_number helper function |
| |
On Wed, Dec 14, 2011 at 11:04 AM, Rob Herring <robherring2@gmail.com> wrote: > Dong, > > On 12/14/2011 10:03 AM, Dong Aisheng wrote: >> From: Dong Aisheng <dong.aisheng@linaro.org> >> >> Currently most code to get child number in kernel are almost same, >> add a helper to implement this function for dt to use. >> >> Signed-off-by: Dong Aisheng <dong.aisheng@linaro.org> >> Cc: Grant Likely <grant.likely@secretlab.ca> >> Cc: Rob Herring <rob.herring@calxeda.com> >> --- >> include/linux/of.h | 17 +++++++++++++++++ >> 1 files changed, 17 insertions(+), 0 deletions(-) >> >> diff --git a/include/linux/of.h b/include/linux/of.h >> index 4948552..09d53dc 100644 >> --- a/include/linux/of.h >> +++ b/include/linux/of.h >> @@ -189,6 +189,18 @@ extern struct device_node *of_get_next_child(const struct device_node *node, >> for (child = of_get_next_child(parent, NULL); child != NULL; \ >> child = of_get_next_child(parent, child)) >> >> +static inline int of_get_child_number(struct device_node *np) > > I would call this of_get_child_count instead.
I agree.
> > Rob
-- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |