Messages in this thread | | | Date | Wed, 14 Dec 2011 00:02:29 +0100 | Subject | Re: [PATCH V2 2/2] ARM: mmp: enable pinmux in platform driver | From | Linus Walleij <> |
| |
On Tue, Dec 13, 2011 at 10:40 AM, Haojian Zhuang <haojian.zhuang@marvell.com> wrote:
> Only enable pinmux in brownstone/aspenite/ttc dkb. > > Signed-off-by: Haojian Zhuang <haojian.zhuang@marvell.com>
A very appetizing and appealing patch, this is looking *very good*. Acked-by: Linus Walleij <linus.walleij@linaro.org>
(But I guess you need the other patch to go in as well...)
> +static struct pinmux_map brownstone_pmx_map[] = { > + { > + .name = "dkin", > + .ctrl_dev_name = "mmp2-pinmux", > + .function = "dkin", > + .group = "dkin-2-pin", > + .hog_on_boot = true, > + }, { > + .name = "uart1", > + .ctrl_dev_name = "mmp2-pinmux", > + .function = "uart1", > + .group = "uart1-4-pin", > + .hog_on_boot = true, > + }, { > + .name = "uart2", > + .ctrl_dev_name = "mmp2-pinmux", > + .function = "uart2", > + .group = "uart2-4-pin", > + .hog_on_boot = true, > + },
Looks like we want to add #define PINMUX_MAP_SYS_HOG_GROUP() or so with four arguments, what do you say Stephen? Shall I try to patch in something like that (then this patch will look even better).
> + PINMUX_MAP_SYS_HOG("uart3", "mmp2-pinmux", "uart3"), > + PINMUX_MAP_SYS_HOG("twsi2", "mmp2-pinmux", "twsi2"), (...)
Thanks, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |