lkml.org 
[lkml]   [2011]   [Dec]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] staging: wlan-ng: prism: coding style fixes, removed space-indentations
From
Date
Hello,

On Tue, Dec 13, 2011 at 7:27 PM, Dan Carpenter
<dan.carpenter@oracle.com> wrote:
> Everyone's first patch is rejected, so don't feel bad. :) Btw put
> these kind of comments which you don't want in the permanent git log
> under the --- dashes. git am removes that information.
Thanks for the feedback! I'm glad I managed git send-email without
breaking up something, so no offense taken that the patch got rejected.

> It looks like you've tried to make everything aligned with the right
> hand side of the screen. I think that's the first time I've seen
> someone do that. I don't think it's normal.
Thank god! I am working on a kmodule, and the code looks awful that way.
I think I have to dig deeper into CodingStyle.txt

>> -----------------------------------------------------------------*/
>> +*----------------------------------------------------------------*/
>
> There is a normal kernel comment style described in Chapter 8 of
> Documentation/CodingStyle.
Now I am confused, as I understand multi-line comments should start
every line but the first with a *.
Anyway, one should commit code before bothering about comments, so I
silence myself here.

> Documentation/kernel-doc-nano-HOWTO.txt
Printed.

Again, thanks for the feedback! Will work on that and come back later
when I found something in the kernel to work on or when my module leaves
design-phase.

regards,
Dan

--
Dan Luedtke
http://www.danrl.de



\
 
 \ /
  Last update: 2011-12-13 19:53    [from the cache]
©2003-2011 Jasper Spaans