lkml.org 
[lkml]   [2011]   [Dec]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Subjectdrivers/media/video/s5p-fimc/fimc-capture.c: boolean and / or confusion
    From
    Date
    On Tue, 2011-12-13 at 00:06 +0100, roel wrote:
    > The test not [val1] or not [val2] always evaluates to true

    Hello

    Looking at drivers with:

    $ grep -rP --include=*.[ch] "(\b[\w\[\]\>\._\-]+)\s*\!\=\s*[\w\[\]\>\._\-]+\s*\|\|\s*\1\s*\!\=" drivers

    drivers/media/video/s5p-fimc/fimc-capture.c: if (mf->width != tfmt->width || mf->width != tfmt->width) {
    drivers/media/video/s5p-fimc/fimc-capture.c: if (mf->width != tfmt->width || mf->width != tfmt->width)

    Most likely these tests should be:
    if (mf->height != tfmt->height || mf->width != tfmt->width)





    \
     
     \ /
      Last update: 2011-12-13 00:57    [W:4.421 / U:0.024 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site