Messages in this thread | | | Subject | drivers/media/video/s5p-fimc/fimc-capture.c: boolean and / or confusion | From | Joe Perches <> | Date | Mon, 12 Dec 2011 15:55:23 -0800 |
| |
On Tue, 2011-12-13 at 00:06 +0100, roel wrote: > The test not [val1] or not [val2] always evaluates to true
Hello
Looking at drivers with:
$ grep -rP --include=*.[ch] "(\b[\w\[\]\>\._\-]+)\s*\!\=\s*[\w\[\]\>\._\-]+\s*\|\|\s*\1\s*\!\=" drivers
drivers/media/video/s5p-fimc/fimc-capture.c: if (mf->width != tfmt->width || mf->width != tfmt->width) { drivers/media/video/s5p-fimc/fimc-capture.c: if (mf->width != tfmt->width || mf->width != tfmt->width)
Most likely these tests should be: if (mf->height != tfmt->height || mf->width != tfmt->width)
| |