lkml.org 
[lkml]   [2011]   [Dec]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [patch 3/3] [PATCH] prctl: Add PR_SET_MM codes to set up mm_struct entires v3
From
On Mon, Dec 12, 2011 at 12:06 PM, Cyrill Gorcunov <gorcunov@openvz.org> wrote:
> When we restore a task we need to set up text, data and data
> heap sizes from userspace to the values a task had at
> checkpoint time. This patch adds auxilary prctl codes for that.
> ...
> Signed-off-by: Cyrill Gorcunov <gorcunov@openvz.org>

Looks good; I like having this wrapped in CONFIG_CHECKPOINT_RESTORE.

> +#ifdef CONFIG_CHECKPOINT_RESTORE
> +static int prctl_set_mm(int opt, unsigned long addr,
> +                       unsigned long arg4, unsigned long arg5)
> ...
> +#else /* CONFIG_CHECKPOINT_RESTORE */
> +static int prctl_set_mm(int opt, unsigned long addr)

These need to have matching argument lists.

Reviewed-by: Kees Cook <keescook@chromium.org>


-Kees

--
Kees Cook
ChromeOS Security
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2011-12-12 21:41    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site