lkml.org 
[lkml]   [2011]   [Dec]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] Add partition resize function to BLKPG ioctl
On Mon, Dec 12, 2011 at 09:49:07AM -0800, Joe Perches wrote:
> On Mon, 2011-12-12 at 12:43 -0500, Phillip Susi wrote:
> > On 12/12/2011 09:53 AM, Vivek Goyal wrote:
> []
> > > - Can we rename BLKPG_RES_PARTITION to BLKPG_RESIZE_PARTITION. It is
> > > easier to read.
> > BLKPG_DELETE_PARTITION is also easier to read, but the existing code
> > went with DEL. I prefer to stay consistent with the existing code and
> > also use a 3 letter name.
>
> RES is most commonly used for RESOURCE.
>
> If it really needs to be 3 letters, and I don't think
> it does, perhaps BLKPG_RSZ_PARTITION

Agreed. RES does not occur to me as resize but resources. ADD and DEL
are very clear.

Thanks
Vivek


\
 
 \ /
  Last update: 2011-12-12 19:07    [W:0.116 / U:0.152 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site