lkml.org 
[lkml]   [2011]   [Dec]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] kref: add function for reading kref value
From
On Mon, Dec 12, 2011 at 5:02 PM, Greg KH <greg@kroah.com> wrote:
> On Mon, Dec 12, 2011 at 02:44:52PM +0200, Daniel Baluta wrote:
>> We can easily get kref refcount value by accesing
>> kref->refcount but it is better to have a function
>> for this.
>
> No, you should NEVER need the value of the kref, if you do, you are
> doing something wrong.
>
> What code needs this patch?

I plan to replace raw refcount patterns from net/ with kref, and
I have noticed that there are some parts of code who need access
to kref->refcount value.

e.g:

core/neighbour.c:152: if (atomic_read(&n->refcnt) == 1 &&
core/neighbour.c:801: if (atomic_read(&n->refcnt) == 1 &&
sched/cls_u32.c:459: if (ht->refcnt == 1) {

thanks,
Daniel.


\
 
 \ /
  Last update: 2011-12-12 16:23    [from the cache]
©2003-2011 Jasper Spaans