Messages in this thread | | | Date | Mon, 12 Dec 2011 14:55:45 +0200 | Subject | Re: [PATCH] kref: add function for reading kref value | From | Daniel Baluta <> |
| |
On Mon, Dec 12, 2011 at 2:51 PM, Belisko Marek <marek.belisko@gmail.com> wrote: > On Mon, Dec 12, 2011 at 1:44 PM, Daniel Baluta <dbaluta@ixiacom.com> wrote: >> We can easily get kref refcount value by accesing >> kref->refcount but it is better to have a function >> for this. >> >> Signed-off-by: Daniel Baluta <dbaluta@ixiacom.com> >> --- >> include/linux/kref.h | 1 + >> lib/kref.c | 9 +++++++++ >> 2 files changed, 10 insertions(+), 0 deletions(-) >> >> diff --git a/include/linux/kref.h b/include/linux/kref.h >> index d4a62ab..cd1b04a 100644 >> --- a/include/linux/kref.h >> +++ b/include/linux/kref.h >> @@ -22,6 +22,7 @@ struct kref { >> }; >> >> void kref_init(struct kref *kref); >> +atomic_t kref_read(struct kref *kref); >> void kref_get(struct kref *kref); >> int kref_put(struct kref *kref, void (*release) (struct kref *kref)); >> int kref_sub(struct kref *kref, unsigned int count, >> diff --git a/lib/kref.c b/lib/kref.c >> index 3efb882..48aaf2a 100644 >> --- a/lib/kref.c >> +++ b/lib/kref.c >> @@ -25,6 +25,15 @@ void kref_init(struct kref *kref) >> smp_mb(); >> } >> >> +/** >> + * kref_read - read refcount for object >> + * @kref: object. >> + */ >> +void kref_read(struct kref *kref) >> +{ >> + return atomic_read(&kref->refcount); >> +} > Return void? Shouldn't be: atomic_t. Did you compile your code before > submission???
You are right. I'll send again with the correct version.
thanks, Daniel. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |