lkml.org 
[lkml]   [2011]   [Dec]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH] mm: memcg: keep root group unchanged if fail to create new
    From
    Hello Hugh

    On Mon, Dec 12, 2011 at 7:39 AM, Hugh Dickins <hughd@google.com> wrote:
    > On Sun, 11 Dec 2011, Hillf Danton wrote:
    >
    >> If the request is not to create root group and we fail to meet it,
    >> we'd leave the root unchanged.
    >
    > I didn't understand that at first: please say "we should" rather
    > than "we'd", which I take to be an abbreviation for "we would".
    >

    Thanks for correcting me.

    >
    > I wonder what was going through the author's mind when he wrote it
    > that way?  I wonder if it's one of those bugs that creeps in when
    > you start from a perfectly functional patch, then make refinements
    > to suit feedback from reviewers.
    >

    Actually no such a perfectly functional patch, but I also wonder if
    you are likely to post and/or share your current todo list if any,
    then many could learn the right direction, and in turn you comment
    and pull acceptable works in that direction, like Linus.

    Hillf
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2011-12-12 13:51    [W:0.027 / U:32.116 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site