lkml.org 
[lkml]   [2011]   [Dec]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
Subjectquestion about link_mem_sections()
Robin,

you added find_memory_block_hinted() with:
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux.git;a=commitdiff;h=63d027a63888e993545d10fdfe4107d543f01bca

I try to understand what's going on here, because we need to switch
away from 'struct sysdev'.

In the loop over the node data you call find_memory_block_hinted() in
a row, which might all take a reference. At the end of the section you
drop only the last reference of the iteration. The code before your
change dropped all references inside the loop.

Could you please explain the intended behaviour?

If all is right, we should at least move the now wrong comment where is belongs.

Thanks,
Kay


\
 
 \ /
  Last update: 2011-12-12 13:39    [from the cache]
©2003-2011 Jasper Spaans