lkml.org 
[lkml]   [2011]   [Dec]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH -next] proc: fix task_struct infoleak
On Sun, Dec 11, 2011 at 20:59 +0000, Al Viro wrote:
> On Sun, Dec 11, 2011 at 10:28:21PM +0400, Vasiliy Kulikov wrote:
> > proc_pid_permission() doesn't put task_struct on every /proc/$pid/
> > access. A demo from Hugh Dickins:
> >
> > while :; do ps; grep KernelStack /proc/meminfo; sleep 1; done
> >
> > Reported-by: Hugh Dickins <hughd@google.com>
> > Signed-off-by: Vasiliy Kulikov <segoon@openwall.com>
> > ---
> > This is a patch against a hidepid patchset from -mm.
>
> Choose saner commit summary, please. It's not information leak, for pity sake
> - it's a plain and simple memory leak...

Oops! s/infoleak/memleak/ surely, bad habit...

Thank you, I'll resend the patch.


--
Vasiliy Kulikov
http://www.openwall.com - bringing security into open computing environments


\
 
 \ /
  Last update: 2011-12-12 12:37    [W:0.038 / U:0.804 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site