lkml.org 
[lkml]   [2011]   [Dec]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] Input: bcm5974 - Fix USB autosuspend
On Mon, Dec 12, 2011 at 10:02:52AM +0100, Oliver Neukum wrote:
> Am Montag, 12. Dezember 2011, 10:06:04 schrieb Henrik Rydberg:
> > @@ -895,6 +857,10 @@ static int bcm5974_probe(struct usb_interface *iface,
> > /* save our data pointer in this interface device */
> > usb_set_intfdata(iface, dev);
> >
> > + error = bcm5974_start_traffic(dev);
> > + if (error)
> > + goto err_free_buffer;
> > +
> > return 0;
> >
> > err_free_buffer:
> > --
>
> Why do you want to start traffic before open() in probe() ?
> It doesn't make sense to ask a device to deliver data nobody
> wants.

Seems I was a bit trigger happy here, will send another one.

Thanks,
Henrik


\
 
 \ /
  Last update: 2011-12-12 11:15    [W:0.028 / U:1.932 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site