lkml.org 
[lkml]   [2011]   [Dec]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 02/06] MFD: DA9052/53 MFD core module v9 Added ADC support
On Fri, Dec 09, 2011 at 07:46:06PM +0530, Ashish Jangam wrote:

> + req = kzalloc(sizeof(*req), GFP_KERNEL);
> + if (!req)
> + return -ENOMEM;

> + init_completion(&req->done);
> + req->input = channel;
> +
> + if (channel > DA9052_ADC_VBBAT)
> + return -EINVAL;

This will leak the request.

> + list_del(&req->list);
> +err:
> + mutex_unlock(&da9052->auxadc_lock);
> + return ret;
> +}
> +EXPORT_SYMBOL_GPL(da9052_adc_manual_read);

In fact is req freed at all?


\
 
 \ /
  Last update: 2011-12-12 05:55    [W:0.070 / U:1.952 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site