lkml.org 
[lkml]   [2011]   [Dec]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] [media] uvcvideo: Use kcalloc instead of kzalloc to allocate array
Date
Hi Thomas,

Thanks for the patch.

On Tuesday 29 November 2011 22:08:00 Thomas Meyer wrote:
> The advantage of kcalloc is, that will prevent integer overflows which
> could result from the multiplication of number of elements and size and it
> is also a bit nicer to read.
>
> The semantic patch that makes this change is available
> in https://lkml.org/lkml/2011/11/25/107
>
> Signed-off-by: Thomas Meyer <thomas@m3y3r.de>

Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

Should I take the patch in my tree, or do you plan to push several similar
patches directly in one go ?

> ---
>
> diff -u -p a/drivers/media/video/uvc/uvc_ctrl.c
> b/drivers/media/video/uvc/uvc_ctrl.c ---
> a/drivers/media/video/uvc/uvc_ctrl.c 2011-11-28 19:36:47.613437745 +0100
> +++ b/drivers/media/video/uvc/uvc_ctrl.c 2011-11-28 19:58:26.309317018
> +0100 @@ -1861,7 +1861,7 @@ int uvc_ctrl_init_device(struct uvc_devi
> if (ncontrols == 0)
> continue;
>
> - entity->controls = kzalloc(ncontrols * sizeof(*ctrl),
> + entity->controls = kcalloc(ncontrols, sizeof(*ctrl),
> GFP_KERNEL);
> if (entity->controls == NULL)
> return -ENOMEM;

--
Regards,

Laurent Pinchart


\
 
 \ /
  Last update: 2011-12-12 00:43    [W:0.086 / U:2.092 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site