lkml.org 
[lkml]   [2011]   [Dec]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] vmscan/trace: Add 'active' and 'file' info to trace_mm_vmscan_lru_isolate.
    On 12/11/2011 12:29 AM, KOSAKI Motohiro wrote:
    > (12/10/11 11:10 AM), Tao Ma wrote:
    >> From: Tao Ma<boyu.mt@taobao.com>
    >>
    >> In trace_mm_vmscan_lru_isolate, we don't output 'active' and 'file'
    >> information to the trace event and it is a bit inconvenient for the
    >> user to get the real information(like pasted below).
    >> mm_vmscan_lru_isolate: isolate_mode=2 order=0 nr_requested=32 nr_scanned=32
    >> nr_taken=32 contig_taken=0 contig_dirty=0 contig_failed=0
    >>
    >> So this patch adds these 2 info to the trace event and it now looks like:
    >> mm_vmscan_lru_isolate: isolate_mode=2 order=0 nr_requested=32 nr_scanned=32
    >> nr_taken=32 contig_taken=0 contig_dirty=0 contig_failed=0 lru=1,0
    >
    > addition is ok to me. but lru=1,0 is not human readable. I suspect
    > people will easily forget which value is active.
    Sure, I can change it to something like "active=1,file=0".
    Maybe I am too worried about the memory used.
    So if there is no objection, I will change it.

    Thanks
    Tao


    \
     
     \ /
      Last update: 2011-12-11 02:43    [W:0.021 / U:89.784 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site