lkml.org 
[lkml]   [2011]   [Dec]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] arm: add default value for PHYS_OFFSET Kconfig setting
From
On Thu, Dec 1, 2011 at 9:19 AM, Arnd Bergmann <arnd@arndb.de> wrote:
> On Thursday 01 December 2011, Paul Gortmaker wrote:
>> Commit 1b9f95f8ade9efc2bd49f0e7b9dc61a038ac3eef introduced the new
>> Kconfig for PHYS_OFFSET but it did not specify a default value.
>>
>> This has the undesired side effect of breaking an implictly used
>> trick for updating defconfigs on the fly for routine buildtesting
>> across all arch and all platforms, i.e.
>>
>>   cp /path/to/somedefconfig .config ; yes "" | make oldconfig
>>
>
> FWIW, a better way to achieve the above is using
>
> make KCONFIG_ALLCONFIG=/path/to/somedefconfig listnewconfig alldefconfig
>
> which does not have this problem.
>
> Your patch looks still ok, but you might want to update your scripts
> to be more robust.

Thanks -- but on the other hand, the above use case does actually
emulate exactly what happens when someone runs the
"make oldconfig" and simply holds down the Enter key. (yes it
happens probably way more than we want to know...)

So, I guess what I'm trying to say is that the above "script" is
intentionally fragile. :) As a use case, we shouldn't break it.

Thanks,
Paul.

>
>        Arnd
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2011-12-02 05:49    [W:0.061 / U:0.508 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site