Messages in this thread | | | Date | Thu, 1 Dec 2011 20:32:13 -0500 | Subject | Re: [PATCH 1/3] serial: make bugs field not specific to 8250 type uarts. | From | Paul Gortmaker <> |
| |
On Thu, Dec 1, 2011 at 7:51 PM, Alan Cox <alan@linux.intel.com> wrote: >> Make the bugs field part of the globally visible struct >> uart_port and remove the 8250 specific one. > > Except all the bits in it are 8250 specific things or names that are > meaningless in generic form - no. I also don't want to encourage flags > and bug bits. We already have too many and its making the code a mess. > So right now we want less not more.
The bits in "bugs" are only passed through -- the idea is that there is no "interpretation" of them by any generic layer -- only that they prop from the arch down to the driver which knows what they mean.
I can understand the "want less not more" mentality -- I was thinking the same thing when I was looking at the replication of fields between uart_port and uart_8250_port, and toying with the idea of helping clean that up.... (separate topic, to be sure.)
If you have an idea in mind how arch/platform code should cleanly pass data about known uart bugs to the uart driver, then let me know what you have in mind. I've no real attachment to what I proposed here -- it just happened to be the solution I thought would be the least offensive. If there is a better idea floating around, I'll go ahead and try to implement it.
Thanks, Paul.
> -- > To unsubscribe from this list: send the line "unsubscribe linux-serial" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |