lkml.org 
[lkml]   [2011]   [Dec]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] jump_label: jump_label for boot options.
On Thu, 1 Dec 2011 10:40:36 -0500
Jason Baron <jbaron@redhat.com> wrote:

> On Thu, Dec 01, 2011 at 11:53:53AM +0900, KAMEZAWA Hiroyuki wrote:
> > I tried to use jump_label for handling memcg's boot options which sets
> > global variable true/false and never changes after boot. And found jump_table
> > is larger than expected. This patch is a trial to allow to place jump_table
> > in .init section. How do you think ?
> >
>
> Remeber too, that 'static_branch()' is inherently biased. That is, the
> 'false' path is assumed to be the the most likely path. Thus, the 'true'
> path is move out-of-line. Thus, if the 'true' branch is potentially
> used all the time, we would want to make sure that the savings of not
> having to check a variable is still worth it. I should probably rename
> static_branch() -> 'static_branch_default_false()' to make that clear.
>
Thank you for pointing out.

My assumption is that it's disabled at boot by few people because sane
people will not config memcg if they don't want. Most of distro users
will not turn off it...



Thanks,
-Kame



\
 
 \ /
  Last update: 2011-12-02 01:31    [W:0.154 / U:0.100 seconds]
©2003-2014 Jasper Spaans. Advertise on this site