lkml.org 
[lkml]   [2011]   [Nov]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[246/264] mtd: mtdchar: add missing initializer on raw write
    3.1-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Peter Wippich <pewi@gw-instruments.de>

    commit bf5140817b2d65faac9b32fc9057a097044ac35b upstream.

    On writes in MODE_RAW the mtd_oob_ops struct is not sufficiently
    initialized which may cause nandwrite to fail. With this patch
    it is possible to write raw nand/oob data without additional ECC
    (either for testing or when some sectors need different oob layout
    e.g. bootloader) like
    nandwrite -n -r -o /dev/mtd0 <myfile>

    Signed-off-by: Peter Wippich <pewi@gw-instruments.de>
    Tested-by: Ricard Wanderlof <ricardw@axis.com>
    Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

    ---
    drivers/mtd/mtdchar.c | 1 +
    1 file changed, 1 insertion(+)

    --- a/drivers/mtd/mtdchar.c
    +++ b/drivers/mtd/mtdchar.c
    @@ -320,6 +320,7 @@ static ssize_t mtd_write(struct file *fi
    ops.mode = MTD_OOB_RAW;
    ops.datbuf = kbuf;
    ops.oobbuf = NULL;
    + ops.ooboffs = 0;
    ops.len = len;

    ret = mtd->write_oob(mtd, *ppos, &ops);



    \
     
     \ /
      Last update: 2011-11-10 04:57    [W:5.957 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site