Messages in this thread Patch in this message | | | Date | Wed, 9 Nov 2011 20:52:35 +0100 | Subject | Re: [PATCH] [TRIVIAL] 8250_hp300: Fix warning typo 'CONFIG_8250' | From | Geert Uytterhoeven <> |
| |
Hi Paul,
On Tue, Nov 8, 2011 at 10:34, Paul Bolle <pebolle@tiscali.nl> wrote: > On Tue, 2011-11-08 at 10:26 +0100, Jiri Kosina wrote: >> On Mon, 7 Nov 2011, Paul Bolle wrote: >> > 1) If SERIAL_8250_HP300 is set but neither HPDCA nor HPAPCI are set we >> > end up with an elaborate nop, don't we? Initialization should always >> > fail in that case. So effectively SERIAL_8250_HP300 depends on HPDCA >> > and/or HPAPCI. Was there perhaps some problem in translating that >> > dependency into a Kconfig dependency? > > [...] > >> > --- a/drivers/tty/serial/8250_hp300.c >> > +++ b/drivers/tty/serial/8250_hp300.c >> > @@ -21,7 +21,7 @@ >> > #include "8250.h" >> > >> > #if !defined(CONFIG_HPDCA) && !defined(CONFIG_HPAPCI) >> > -#warning CONFIG_8250 defined but neither CONFIG_HPDCA nor CONFIG_HPAPCI defined, are you sure? >> > +#warning CONFIG_SERIAL_8250 defined but neither CONFIG_HPDCA nor CONFIG_HPAPCI defined, are you sure? >> > #endif >> >> What is the point of this warning anyway? Shouldn't everything necessary >> be taken care of by Kconfig rules? > > That's exactly what I'm trying to find out with my questions (aimed at > the m68k people, see 1) above).
I have this reminder in my local tree:
diff --git a/arch/m68k/Kconfig.devices b/arch/m68k/Kconfig.devices index 6033f5d..354ce91 100644 --- a/arch/m68k/Kconfig.devices +++ b/arch/m68k/Kconfig.devices @@ -109,6 +109,7 @@ config MULTIFACE_III_TTY To compile this driver as a module, choose M here.
config HPDCA + # FIXME Should be bool and select SERIAL_8250_HP300? tristate "HP DCA serial support" depends on DIO && SERIAL_8250 help @@ -116,6 +117,7 @@ config HPDCA machine, say Y here.
config HPAPCI + # FIXME Should be bool and select SERIAL_8250_HP300? tristate "HP APCI serial support" depends on HP300 && SERIAL_8250 && EXPERIMENTAL help However, if these two options are bool, SERIAL_8250_HP300 can never be m anymore.
Ah, if we just kill SERIAL_8250_HP300, we can put in the Makefile:
obj-$(CONFIG_HPDCA) += 8250_hp300.o obj-$(CONFIG_HPAPCI) += 8250_hp300.o
Does that make sense?
Gr{oetje,eeting}s, Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |