Messages in this thread |  | | | Date | Wed, 9 Nov 2011 08:09:21 +0200 | | From | Felipe Balbi <> | | Subject | Re: [PATCH v2 1/2] USB-musb: move to dma_transfer_direction |
| |
On Fri, Oct 14, 2011 at 10:09:09PM +0530, Vinod Koul wrote: > fixup usage of dma direction by introducing dma_transfer_direction, > this patch moves usb/musb driver to use new enum > > Signed-off-by: Vinod Koul <vinod.koul@linux.intel.com> > Cc: Felipe Balbi <balbi@ti.com> > Cc: Greg Kroah-Hartman <gregkh@suse.de>
This looks ok to me:
Acked-by: Felipe Balbi <balbi@ti.com>
Mian, if you agree with this patch, please reply with your Acked-by
> --- > v2: split the usb patch into two patches > fix the error of direction variable > > drivers/usb/musb/ux500_dma.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/usb/musb/ux500_dma.c b/drivers/usb/musb/ux500_dma.c > index ef4333f..d5b5262 100644 > --- a/drivers/usb/musb/ux500_dma.c > +++ b/drivers/usb/musb/ux500_dma.c > @@ -112,7 +112,7 @@ static bool ux500_configure_channel(struct dma_channel *channel, > struct musb_hw_ep *hw_ep = ux500_channel->hw_ep; > struct dma_chan *dma_chan = ux500_channel->dma_chan; > struct dma_async_tx_descriptor *dma_desc; > - enum dma_data_direction direction; > + enum dma_transfer_direction direction; > struct scatterlist sg; > struct dma_slave_config slave_conf; > enum dma_slave_buswidth addr_width; > @@ -132,7 +132,7 @@ static bool ux500_configure_channel(struct dma_channel *channel, > sg_dma_address(&sg) = dma_addr; > sg_dma_len(&sg) = len; > > - direction = ux500_channel->is_tx ? DMA_TO_DEVICE : DMA_FROM_DEVICE; > + direction = ux500_channel->is_tx ? MEM_TO_DEV : DEV_TO_MEM; > addr_width = (len & 0x3) ? DMA_SLAVE_BUSWIDTH_1_BYTE : > DMA_SLAVE_BUSWIDTH_4_BYTES; > > -- > 1.7.0.4 >
-- balbi [unhandled content-type:application/pgp-signature] |  |