lkml.org 
[lkml]   [2011]   [Nov]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCHv6 01/19] usb: otg: Rename otg_transceiver to usb_phy
From
Hi Heikki,

On Fri, Oct 28, 2011 at 6:05 PM, Heikki Krogerus
<heikki.krogerus@linux.intel.com> wrote:
> This is the first step in separating USB transceivers from
> USB OTG utilities.
>
> Includes fixes to IMX code from Sascha Hauer.

I tend to defer with your opinion of renaming otg_transceiver to
usb_phy. According to me otg_transceiver should program hardware
mechanisms associated to VBUS, ID lines, etc.. and phy is responsible
for transmitting data over differential data lines (with its own
programming of phy_init, phy_shutdown, setting phy clocks etc..). So
in my opinion otg_transceiver and usb_phy should be two different and
separate entities.

I would have preferred to rename otg_transceiver as usb_otg as the
first step. (this differs from your implementation where you rename
otg_transceiver to usb_phy and create a new structure usb_otg to
separate otg members from usb_phy).

But it should have been first rename otg_transceiver as usb_otg. Then
create a new structure usb_phy to move all the phy specific
implementation there. This kind of implementation will also help when
we want to have independent phy drivers.

Thanks
Kishon


\
 
 \ /
  Last update: 2011-11-08 06:59    [W:0.254 / U:0.276 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site