lkml.org 
[lkml]   [2011]   [Nov]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] virtio-pci: fix use after free
On (Mon) 07 Nov 2011 [18:37:05], Michael S. Tsirkin wrote:
> Commit 31a3ddda166cda86d2b5111e09ba4bda5239fae6 introduced
> a use after free in virtio-pci. The main issue is
> that the release method signals removal of the virtio device,
> while remove signals removal of the pci device.
>
> For example, on driver removal or hot-unplug,
> virtio_pci_release_dev is called before virtio_pci_remove.
> We then might get a crash as virtio_pci_remove tries to use the
> device freed by virtio_pci_release_dev.
>
> We allocate/free all resources together with the
> pci device, so we can leave the release method empty.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>

Acked-by: Amit Shah <amit.shah@redhat.com>

(note: Adding CC: stable@kernel.org to the commit log is the way
patches get automatically pulled from upstream when committed; CC'ing
stable on submissions won't help with that.)

Amit


\
 
 \ /
  Last update: 2011-11-08 06:49    [from the cache]
©2003-2011 Jasper Spaans