lkml.org 
[lkml]   [2011]   [Nov]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCHv3 2/2] msm: Support DEBUG_LL on MSM8660 and MSM8960
On Tue, 8 Nov 2011, Stephen Boyd wrote:

> Add support for DEBUG_LL on the 8660 and 8960 development boards.
> While we're here cleanup the uncompress.h code a bit. Avoid
> the use of readl/writel as those are Linux specific APIs that
> aren't guaranteed to work in the decompressor.
>
> Cc: Nicolas Pitre <nico@fluxnic.net>
> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>

Acked-by: Nicolas Pitre <nico@linaro.org>

Independently from this patch, I was wondering about this code:

> + .macro senduart, rd, rx
> +#ifdef CONFIG_MSM_HAS_DEBUG_UART_HS
> + @ Write the 1 character to UARTDM_TF
> + str \rd, [\rx, #0x70]
> +#else
> teq \rx, #0
> strne \rd, [\rx, #0x0C]
> +#endif
> .endm

Why testing for zero in the #else part? The upper level code should
never call this macro with a null byte.


Nicolas


\
 
 \ /
  Last update: 2011-11-08 20:11    [W:0.088 / U:0.116 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site