lkml.org 
[lkml]   [2011]   [Nov]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 13/13] drm/i915: don't clobber userspace memory before commiting to the pread
    Date
    The pagemap.h prefault helpers do the prefaulting by simply writing
    some data into every page. Hence we should not prefault when we're not
    yet commited to to actually writing data to userspace. The problem is
    now that
    - we can't prefault while holding dev->struct_mutex for we could
    deadlock with our own pagefault handler
    - we need to grab dev->struct_mutex before copying to sync up with any
    outsanding gpu writes.

    Therefore only prefault when we're dropping the lock the first time in
    the pread slowpath - at that point we're committed to the write, don't
    wait on the gpu anymore and hence won't return early (with e.g.
    -EINTR).

    Signed-Off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
    ---
    drivers/gpu/drm/i915/i915_gem.c | 16 +++++++++++-----
    1 files changed, 11 insertions(+), 5 deletions(-)

    diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c
    index 0a374e1..ebaa0f0 100644
    --- a/drivers/gpu/drm/i915/i915_gem.c
    +++ b/drivers/gpu/drm/i915/i915_gem.c
    @@ -338,6 +338,7 @@ i915_gem_shmem_pread(struct drm_device *dev,
    int shmem_page_offset, page_length, ret;
    int obj_do_bit17_swizzling, page_do_bit17_swizzling;
    int hit_slowpath = 0;
    + int prefaulted = 0;
    int needs_clflush = 0;
    int release_page;

    @@ -408,6 +409,16 @@ i915_gem_shmem_pread(struct drm_device *dev,

    mutex_unlock(&dev->struct_mutex);

    + if (!prefaulted) {
    + ret = fault_in_pages_writeable(user_data, remain);
    + /* Userspace is tricking us, but we've already clobbered
    + * its pages with the prefault and promised to write the
    + * data up to the first fault. Hence ignore any errors
    + * and just continue. */
    + (void)ret;
    + prefaulted = 1;
    + }
    +
    vaddr = kmap(page);
    if (needs_clflush)
    drm_clflush_virt_range(vaddr + shmem_page_offset,
    @@ -470,11 +481,6 @@ i915_gem_pread_ioctl(struct drm_device *dev, void *data,
    args->size))
    return -EFAULT;

    - ret = fault_in_pages_writeable((char __user *)(uintptr_t)args->data_ptr,
    - args->size);
    - if (ret)
    - return -EFAULT;
    -
    ret = i915_mutex_lock_interruptible(dev);
    if (ret)
    return ret;
    --
    1.7.6.4


    \
     
     \ /
      Last update: 2011-11-06 20:17    [W:0.022 / U:31.064 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site