Messages in this thread | | | Date | Fri, 4 Nov 2011 16:40:09 +0000 | From | Mark Brown <> | Subject | Re: [PATCH 2/2] regulator:TPS65910: VDD1/2 voltage selector count |
| |
On Fri, Nov 04, 2011 at 04:32:43PM +0000, Mohammed, Afzal wrote: > On Fri, Nov 04, 2011 at 21:48:56, Mark Brown wrote: > > So that definitely seems wrong then - n_voltages is supposed to be the > > number of voltages that can be selected so if the regulator supports > > _NUM_VOLTS steps then I'd expect to see that constant used directly. > > Otherwise I'd suggest that the magic number needs a #define.
> A gain of 0x1, 0x2, 0x3 is possible for each of the voltage steps, > so we have a total of _NUM_VOLTS * 3 steps (although some of them > would be same values).
What do you mean when you say "gain"?
| |