| Date | Wed, 30 Nov 2011 19:57:51 +0100 | From | Oleg Nesterov <> | Subject | Re: [PATCH v7 3.2-rc2 8/30] x86: analyze instruction and determine fixups. |
| |
On 11/18, Srikar Dronamraju wrote: > > +static void handle_riprel_insn(struct mm_struct *mm, struct uprobe *uprobe, > + struct insn *insn) > +{ > [...snip...] > + if (insn->immediate.nbytes) { > + cursor++; > + memmove(cursor, cursor + insn->displacement.nbytes, > + insn->immediate.nbytes); > + } > + return; > +}
Of course I don not understand this code. But it seems that it can rewrite uprobe->insn ?
If yes, don't we need to save the original insn for unregister_uprobe?
Oleg.
|