lkml.org 
[lkml]   [2011]   [Nov]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH RFC 0/5] uprobes: kill xol vma
    From
    Date
    On Wed, 2011-11-30 at 17:15 +0100, Andi Kleen wrote:
    > > static unsigned char
    > > -uprobe_xol_slots[UPROBES_XOL_SLOT_BYTES][NR_CPUS] __page_aligned_bss;
    > > +uprobe_xol_slots[NR_CPUS][UPROBES_XOL_SLOT_BYTES] __page_aligned_bss;
    >
    > NR_CPUS arrays are basically always wrong.
    >
    > Use per cpu data.

    Doesn't really work here, you'd know if you'd read the patches. What we
    could do though is do a UPROBES_XOL_SLOT_BYTES * nr_cpu_ids bootmem
    allocation or so.


    \
     
     \ /
      Last update: 2011-11-30 17:23    [W:4.160 / U:25.936 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site