Messages in this thread | | | Subject | Re: [PATCH RFC 0/5] uprobes: kill xol vma | From | Peter Zijlstra <> | Date | Wed, 30 Nov 2011 17:20:31 +0100 |
| |
On Wed, 2011-11-30 at 17:15 +0100, Andi Kleen wrote: > > static unsigned char > > -uprobe_xol_slots[UPROBES_XOL_SLOT_BYTES][NR_CPUS] __page_aligned_bss; > > +uprobe_xol_slots[NR_CPUS][UPROBES_XOL_SLOT_BYTES] __page_aligned_bss; > > NR_CPUS arrays are basically always wrong. > > Use per cpu data.
Doesn't really work here, you'd know if you'd read the patches. What we could do though is do a UPROBES_XOL_SLOT_BYTES * nr_cpu_ids bootmem allocation or so.
| |