lkml.org 
[lkml]   [2011]   [Nov]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    SubjectRe: sb_edac 32-bit compile fail due to 64-bit divide
    On Thu, Nov 03, 2011 at 03:41:52PM -0200, Mauro Carvalho Chehab wrote:
    > Em 03-11-2011 14:31, Luck, Tony escreveu:
    > >>> Of course, an interim fix would be to make it depend on CONFIG_64BIT or CONFIG_X86_64.
    > >>
    > >> That would work I guess. It's up to you.
    > >
    > > Typically the test platforms I get have pretty much the minimum sane memory
    > > configuration - my Sandy Bridge EP machine came with 32GB of memory (which
    > > is theoretically bootable with a 32-bit kernel, but really isn't going to
    > > be much fun to use). So I would think that time could be spent on more
    > > productive things than making this edac driver work on 32-bit. My vote
    > > is for the "depends on 64-bit" solution.
    >
    > Works for me. It would be a trivial patch. We can later fix it for 32 bits, if
    > someone has any usage for it with 32 bits kernels.

    How's the below?

    josh

    ---

    From: Josh Boyer <jwboyer@redhat.com>
    Subject: [PATCH] edac: Only build sb_edac on 64-bit

    The sb_edac driver is marginally useful on a 32-bit kernel, and
    currently has 64-bit divide compile errors when building that config.
    For now, make this build on only for 64-bit kernels.

    Signed-off-by: Josh Boyer <jwboyer@redhat.com>

    ---

    diff --git a/drivers/edac/Kconfig b/drivers/edac/Kconfig
    index 203361e..5948a21 100644
    --- a/drivers/edac/Kconfig
    +++ b/drivers/edac/Kconfig
    @@ -214,7 +214,7 @@ config EDAC_I7300

    config EDAC_SBRIDGE
    tristate "Intel Sandy-Bridge Integrated MC"
    - depends on EDAC_MM_EDAC && PCI && X86 && X86_MCE_INTEL
    + depends on EDAC_MM_EDAC && PCI && X86_64 && X86_MCE_INTEL
    depends on EXPERIMENTAL
    help
    Support for error detection and correction the Intel

    \
     
     \ /
      Last update: 2011-11-03 18:51    [W:0.055 / U:0.012 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site