lkml.org 
[lkml]   [2011]   [Nov]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 16/28] namespace: checkpatch wanking
From
Date
On Wed, 2011-11-30 at 02:22 +0000, Al Viro wrote:
> On Tue, Nov 29, 2011 at 06:14:14PM -0800, Joe Perches wrote:
> > Fix a few style things.
> > $ ./scripts/checkpatch.pl -f --terse --nosummary fs/namespace.c | \
> > cut -f3- -d":" | sort | uniq -c
> > 1 ERROR: do not initialise statics to 0 or NULL
> > 2 ERROR: do not use assignment in if condition
> > 1 ERROR: "foo * bar" should be "foo *bar"
> > 1 ERROR: need consistent spacing around '|' (ctx:VxW)
> > 1 WARNING: braces {} are not necessary for single statement blocks
> > 3 WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
> > 4 WARNING: line over 80 characters
> > 9 WARNING: please, no space before tabs
> > 1 WARNING: Use #include <linux/uaccess.h> instead of <asm/uaccess.h>
> > 1 WARNING: Use #include <linux/unistd.h> instead of <asm/unistd.h>
> NAK. First of all, wanking it certainly is; moreover, it creates shitloads
> of conflicts with patches in vfs.git#vfsmount-guts
No worries.

I think patches 1 thru 14 are reasonable though
and do apply with a few offsets to vfsmount-guts.




\
 
 \ /
  Last update: 2011-11-30 04:43    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site