lkml.org 
[lkml]   [2011]   [Nov]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [rfc 1/3] fs, proc: Add start_data, end_data, start_brk members to /proc/$pid/stat
On Tue, Nov 29, 2011 at 11:12:53PM +0400, Cyrill Gorcunov wrote:
> It helps to dump and restore this mm_struct members.
>
> Signed-off-by: Cyrill Gorcunov <gorcunov@openvz.org>
> ---
> fs/proc/array.c | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> Index: linux-2.6.git/fs/proc/array.c
> ===================================================================
> --- linux-2.6.git.orig/fs/proc/array.c
> +++ linux-2.6.git/fs/proc/array.c
> @@ -464,7 +464,7 @@ static int do_task_stat(struct seq_file
>
> seq_printf(m, "%d (%s) %c %d %d %d %d %d %u %lu \
> %lu %lu %lu %lu %lu %ld %ld %ld %ld %d 0 %llu %lu %ld %lu %lu %lu %lu %lu \
> -%lu %lu %lu %lu %lu %lu %lu %lu %d %d %u %u %llu %lu %ld\n",
> +%lu %lu %lu %lu %lu %lu %lu %lu %d %d %u %u %llu %lu %ld %lu %lu %lu\n",
> pid_nr_ns(pid, ns),
> tcomm,
> state,
> @@ -511,7 +511,10 @@ static int do_task_stat(struct seq_file
> task->policy,
> (unsigned long long)delayacct_blkio_ticks(task),
> cputime_to_clock_t(gtime),
> - cputime_to_clock_t(cgtime));
> + cputime_to_clock_t(cgtime),
> + mm ? (permitted ? mm->start_data : 1) : 0,
> + mm ? (permitted ? mm->end_data : 1) : 0,
> + mm ? (permitted ? mm->start_brk : 1) : 0);
> if (mm)
> mmput(mm);
> return 0;

Thanks for using "permitted" here. :)

Reviewed-by: Kees Cook <keescook@chromium.org>

--
Kees Cook


\
 
 \ /
  Last update: 2011-11-29 21:11    [W:0.139 / U:2.160 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site