Messages in this thread | | | Subject | Re: [PATCH] sctp: integer overflow in sctp_auth_create_key() | From | Xi Wang <> | Date | Tue, 29 Nov 2011 14:24:01 -0500 |
| |
Thanks for clarifying this!
I will leave the check there and incorporate your comments into a new patch.
- xi
On Nov 29, 2011, at 10:03 AM, Vladislav Yasevich wrote: > > That should be ok as well. There is an overflow guard in the api > entry point so that should guard against overflows from user space. > > On the network end I miscalculated a little. The key is actually made up > of user_key (1 short) + 2 * key_vector (3 shorts) for a total of 7*MAX_USHORT; > however, that still will not overflow 32 bits. > > -vlad
| |