lkml.org 
[lkml]   [2011]   [Nov]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/5] uprobes: introduce uprobe_switch_to()
On 11/28, Peter Zijlstra wrote:
>
> On Mon, 2011-11-28 at 20:06 +0100, Oleg Nesterov wrote:
> > +void uprobe_switch_to(struct task_struct *curr)
> > +{
> > + struct uprobe_task *utask = curr->utask;
> > + struct pt_regs *regs = task_pt_regs(curr);
> > +
> > + if (!utask || utask->state != UTASK_SSTEP)
> > + return;
> > +
> > + if (!(regs->flags & X86_EFLAGS_TF))
> > + return;
> > +
> > + set_xol_ip(regs);
> > +}
>
> > void __weak set_xol_ip(struct pt_regs *regs)
> > {
> > + int cpu = smp_processor_id();
> > + struct uprobe_task *utask = current->utask;
> > + struct uprobe *uprobe = utask->active_uprobe;
> > +
> > + memcpy(uprobe_xol_slots[cpu], uprobe->insn, MAX_UINSN_BYTES);
> > +
> > + utask->xol_vaddr = fix_to_virt(UPROBE_XOL_FIRST_PAGE)
> > + + UPROBES_XOL_SLOT_BYTES * cpu;
> > + set_instruction_pointer(regs, utask->xol_vaddr);
> > }
>
> So uprobe_switch_to() will always reset the IP to the start of the slot?
> That sounds wrong, things like the RIP relative stuff needs multiple
> instructions.

Hmm. Could you explain? Especially the "multiple instructions" part.

In any case we should reset the IP to the start of the slot.

But yes, I'm afraid this is too simple. Before this patches pre_xol()
is called when we already know ->xol_vaddr. But afaics x86 doesn't use
this info (post_xol() does). So this looks equally correct or wrong.

But perhaps we need another arch-dependent hook which takes ->xol_vaddr
into account instead of simple memcpy(), to handle the RIP relative
case.

Or I misunderstood?


Peter, all, I apologize in advance, I can't be responsive today.

Oleg.



\
 
 \ /
  Last update: 2011-11-29 18:27    [W:0.296 / U:0.168 seconds]
©2003-2014 Jasper Spaans. Advertise on this site