lkml.org 
[lkml]   [2011]   [Nov]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v4] sound/soc/codecs: add LAPIS Semiconductor ML26124
On Tue, Nov 29, 2011 at 09:28:56PM +0900, Tomoya MORINAGA wrote:
> ML26124-01HB/ML26124-02GD is 16bit monaural audio CODEC which has high
> resistance to voltage noise. On chip regulator realizes power supply rejection
> ratio be over 90dB so more than 50dB is improved than ever. ML26124-01HB/

Given the questions you just asked myself and Lars-Peter it seems fairly
clear that the review comments from the previous version so I'm not
going to review this, please resend once the review comments have been
addressed. Lars-Peter concern seemed especially serious, I'd expect
large sections of the audio functionality to not work without being
connected to the DAPM map.

In general if resubmitting code that has outstanding review issues you
should highlight the known issues and explain why you are resending;
usually if there's an active discussion in progress it's better to wait
for that to die down.


\
 
 \ /
  Last update: 2011-11-29 13:53    [W:0.207 / U:0.024 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site