Messages in this thread | | | Subject | Re: [PATCH 3/5] uprobes: introduce uprobe_xol_slots[NR_CPUS] | From | Peter Zijlstra <> | Date | Mon, 28 Nov 2011 20:52:01 +0100 |
| |
On Mon, 2011-11-28 at 20:48 +0100, Peter Zijlstra wrote: > On Mon, 2011-11-28 at 20:07 +0100, Oleg Nesterov wrote: > > + UPROBE_XOL_FIRST_PAGE = UPROBE_XOL_LAST_PAGE > > + + NR_CPUS * UPROBES_XOL_SLOT_BYTES / PAGE_SIZE, > > I think that wants to be: > + DIV_ROUND_UP(NR_CPUS * UPROBES_XOL_SLOT_BYTES, PAGE_SIZE); > > otherwise you'll end up with 0 pages for UP and the sort.
Ah, no I see, you'll already have the one LAST_PAGE thing.
| |