Messages in this thread | | | From | Rabin Vincent <> | Date | Mon, 28 Nov 2011 22:34:15 +0530 | Subject | Re: [PATCH 4/4] ARM: add jump label support |
| |
On Wed, Nov 23, 2011 at 23:23, Russell King - ARM Linux <linux@arm.linux.org.uk> wrote: > On Wed, Nov 23, 2011 at 08:25:09PM +0530, Rabin Vincent wrote: >> +cat << "END" | $@ -x c - -c -o /dev/null >/dev/null 2>&1 && echo "y" >> +int main(void) >> +{ >> +#ifdef __arm__ >> + /* >> + * Not related to asm goto, but used by jump label >> + * and broken on some ARM GCC versions (see GCC Bug 48637). >> + */ >> + static struct { int dummy; int state; } tp; >> + asm ("@ %c0" :: "i" (&tp.state)); >> +#endif >> + >> +entry: >> + asm goto ("" :::: entry); >> + return 0; >> +} >> +END > > Is the presence of asm goto and %c something we want to test together or > separately? I suspect it's something we want to do separately.
Why would we want to do it separately?
The only reason I see is because the results of this test are assigned to a variable called CC_HAVE_ASM_GOTO and that is not an entirely accurate name (on ARM) after the addition of this test. If that's the concern, perhaps this variable could just be renamed? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |