Messages in this thread | | | Date | Sun, 27 Nov 2011 11:35:26 +0200 | From | Igor Grinberg <> | Subject | Re: [PATCH 1/2] gpiolib: introduce gpio_set_pullup |
| |
On 11/25/11 17:34, Mark Brown wrote: > On Fri, Nov 25, 2011 at 03:08:39PM +0100, Jean-Christophe PLAGNIOL-VILLARD wrote: > >> +/** >> + * gpio_set_pullup - sets @pullup for a @gpio >> + * @gpio: the gpio to set pullup >> + * @pullup: pullup level >> + */ >> +int gpio_set_pullup(unsigned gpio, unsigned pullup) > > This has some overlap with the pinmux subsystem. We also need > documentation of what the pullup values mean.
+1
AFAIK, 3 values are there: up, down and highz Also, IMO, this should have no effect if the GPIO is configured for output.
-- Regards, Igor.
| |