Messages in this thread |  | | | Date | Sat, 26 Nov 2011 16:35:15 -0500 (EST) | | Subject | Re: [PATCH 1/1] AF_UNIX: Fix poll locking problem when reading from a stream socket | | From | David Miller <> |
| |
From: Eric Dumazet <eric.dumazet@gmail.com> Date: Tue, 22 Nov 2011 06:23:01 +0100
> Le mardi 22 novembre 2011 à 03:35 +0400, Alexey Moiseytsev a écrit : >> poll() call may be locked by concurrent reading from the same stream >> socket. >> >> Signed-off-by: Alexey Moiseytsev <himeraster@gmail.com> .. > Fine, the fix is technically correct since we own u->readlock mutex, > another thread cannot consume the just requeued skb. > > Small note : the words "locking" and "locked" are more used to describe > the action of taking a spinlock/mutex/rwlock or something, while the bug > you fixed is more about poll() system call being blocked/frozen forever. > > Thanks ! > > Acked-by: Eric Dumazet <eric.dumazet@gmail.com>
Applied, with 'lock{ing,ed}' adjusted to 'block{ing,ed}'. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |