Messages in this thread | | | Date | Thu, 24 Nov 2011 16:36:47 +0100 | From | Marc Kleine-Budde <> | Subject | Re: [PATCH 11/11] can: Remove redundant spi driver bus initialization |
| |
On 11/24/2011 04:29 PM, Lars-Peter Clausen wrote: > In ancient times it was necessary to manually initialize the bus field of an > spi_driver to spi_bus_type. These days this is done in spi_driver_register(), > so we can drop the manual assignment. > > The patch was generated using the following coccinelle semantic patch: > // <smpl> > @@ > identifier _driver; > @@ > struct spi_driver _driver = { > .driver = { > - .bus = &spi_bus_type, > }, > }; > // </smpl> > > Signed-off-by: Lars-Peter Clausen <lars@metafoo.de> > Cc: Wolfgang Grandegger <wg@grandegger.com> > Cc: linux-can@vger.kernel.org
Acked-by: Marc Kleine-Budde <mkl@pengutronix.de> > --- > drivers/net/can/mcp251x.c | 1 - > 1 files changed, 0 insertions(+), 1 deletions(-) > > diff --git a/drivers/net/can/mcp251x.c b/drivers/net/can/mcp251x.c > index 330140e..5e10da5 100644 > --- a/drivers/net/can/mcp251x.c > +++ b/drivers/net/can/mcp251x.c > @@ -1185,7 +1185,6 @@ MODULE_DEVICE_TABLE(spi, mcp251x_id_table); > static struct spi_driver mcp251x_can_driver = { > .driver = { > .name = DEVICE_NAME, > - .bus = &spi_bus_type, > .owner = THIS_MODULE, > }, >
-- Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions | Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917-5555 | Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[unhandled content-type:application/pgp-signature] | |