lkml.org 
[lkml]   [2011]   [Nov]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v7 3.2-rc2 3/30] uprobes: register/unregister probes.
From
Date
On Fri, 2011-11-18 at 16:37 +0530, Srikar Dronamraju wrote:
> +void unregister_uprobe(struct inode *inode, loff_t offset,
> + struct uprobe_consumer *consumer)
> +{
> + struct uprobe *uprobe = NULL;
> +
> + inode = igrab(inode);
> + if (!inode || !consumer)
> + goto unreg_out;

Why do you take a reference on the inode here? Surely inode is already
made stable by whoever calls us?

> + uprobe = find_uprobe(inode, offset);
> + if (!uprobe)
> + goto unreg_out;
> +
> + mutex_lock(uprobes_hash(inode));
> + if (!del_consumer(uprobe, consumer)) {
> + mutex_unlock(uprobes_hash(inode));
> + goto unreg_out;
> + }
> +
> + if (!uprobe->consumers)
> + __unregister_uprobe(inode, offset, uprobe);
> +
> + mutex_unlock(uprobes_hash(inode));
> +
> +unreg_out:
> + if (uprobe)
> + put_uprobe(uprobe);
> + if (inode)
> + iput(inode);
> +}


\
 
 \ /
  Last update: 2011-11-23 17:29    [W:0.374 / U:2.928 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site