Messages in this thread | | | Subject | Re: [patch 4/7] sched: convert rq->avg_idle to rq->avg_event | From | Mike Galbraith <> | Date | Wed, 23 Nov 2011 15:21:15 +0100 |
| |
On Wed, 2011-11-23 at 13:57 +0100, Mike Galbraith wrote: > On Wed, 2011-11-23 at 13:27 +0100, Peter Zijlstra wrote:
> > Now I'm not saying this all isn't worth it, just saying my brain is > > having difficulty seeing how it all makes sense :-) > > They make sense only in that one cheap number generator bandaids three > owies. It's fugly but effective :)
Addendum:
That number represents scheduler busyness. If we're "this" busy, it's not worth entering nohz, there's unlikely to be enough overlap to be worth going after at the expense of L2 misses fro L3 equipped CPUs, and we can't afford to futz around with load balancing just now.
"this" is arbitrary, but in the select_idle_sibling() case at least, it's impossible to know what any wakee will do with the CPU, so you're stuck with arbitrary no matter what you use to shut the thing off.
-Mike
| |