lkml.org 
[lkml]   [2011]   [Nov]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/2] cleanup: convert the int cnt to unsigned long in mm/memblock.c
On 2011年11月23日 07:59, Andrew Morton wrote:
> On Wed, 09 Nov 2011 13:18:53 +0800
> Wang Sheng-Hui <shhuiw@gmail.com> wrote:
>
>> @@ -111,7 +112,7 @@ static phys_addr_t __init_memblock memblock_find_region(phys_addr_t start, phys_
>> static phys_addr_t __init_memblock memblock_find_base(phys_addr_t size,
>> phys_addr_t align, phys_addr_t start, phys_addr_t end)
>> {
>> - long i;
>> + unsigned long i;
>>
>> BUG_ON(0 == size);
>
> This change to memblock_find_base() can cause this loop:
>
> for (i = memblock.memory.cnt - 1; i >= 0; i--) {
>
> to become infinite under some circumstances.
>
> I stopped reading at that point. Changes like this require much care.
>

Got it.

Thanks for your instructions.
I'll review the code and may resubmit the right patches later.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2011-11-23 14:05    [W:0.405 / U:0.028 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site