Messages in this thread | | | Date | Wed, 23 Nov 2011 12:23:08 +0000 | From | Jamie Iles <> | Subject | Re: [PATCH] irq: fix possible null-pointer deref irq_domain_to_irq |
| |
Hi Rob,
On Thu, Nov 10, 2011 at 07:37:32AM -0600, Rob Herring wrote: > On 11/10/2011 05:14 AM, Jamie Iles wrote: > > On Thu, Nov 10, 2011 at 10:53:03AM +0000, Jamie Iles wrote: > >> It is optional for an irqdomain to have a to_irq() method, and for > >> simple domains they often don't require any operations at all - just > >> hwirq to Linux irq translation. Check we have valid ops before > >> dereferencing them. > >> > >> Patch originally by Rob Herring. > >> > >> Suggested-by: Rob Herring <robherring2@gmail.com> > > > > Naturally git send-email doesn't know how to convert this into a CC, so > > Rob is now CC'd! > > > > Jamie > > > >> Cc: Thomas Gleixner <tglx@linutronix.de> > >> Cc: Grant Likely <grant.likely@secretlab.ca> > >> Signed-off-by: Jamie Iles <jamie@jamieiles.com> > >> --- > >> > >> Rob, I can't see that you've already posted this but I didn't want to > >> hold Marc's GIC patches up. > > Thanks. I didn't get around to it yesterday. > > Acked-by: Rob Herring <rob.herring@calxeda.com>
I've just noticed in kernel/irq/irqdomain.c, that the kerneldoc for irq_domain_add() says that a valid ops structure is required, so perhaps this fix isn't right and we should just have an empty ops structure for simple controllers...
Jamie
| |