lkml.org 
[lkml]   [2011]   [Nov]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] vmscan: add task name to warn_scan_unevictable() messages
On Wed, Nov 23, 2011 at 12:55:20AM -0500, KOSAKI Motohiro wrote:
> If we need to know a usecase, caller program name is critical important.
> Show it.
>
> Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
> Cc: Johannes Weiner <hannes@cmpxchg.org>
> ---
> mm/vmscan.c | 5 +++--
> 1 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/mm/vmscan.c b/mm/vmscan.c
> index a1893c0..29d163e 100644
> --- a/mm/vmscan.c
> +++ b/mm/vmscan.c
> @@ -3448,9 +3448,10 @@ void scan_mapping_unevictable_pages(struct address_space *mapping)
> static void warn_scan_unevictable_pages(void)
> {
> printk_once(KERN_WARNING
> - "The scan_unevictable_pages sysctl/node-interface has been "
> + "%s: The scan_unevictable_pages sysctl/node-interface has been "
> "disabled for lack of a legitimate use case. If you have "
> - "one, please send an email to linux-mm@kvack.org.\n");
> + "one, please send an email to linux-mm@kvack.org.\n",
> + current->comm);
> }

Just nitpick:
How about using WARN_ONCE instead of custom warning?
It can show more exact call path as well as comm.
I guess it's more noticible to users.
Anyway, either is okay to me.

--
Kind regards,
Minchan Kim


\
 
 \ /
  Last update: 2011-11-23 07:27    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site