Messages in this thread | | | Date | Wed, 23 Nov 2011 07:24:03 +0100 | Subject | Re: [PATCH 02/15] samsung-laptop: move code into init/exit functions | From | Corentin Chary <> |
| |
On Tue, Nov 22, 2011 at 11:19 PM, Greg KH <gregkh@suse.de> wrote: > On Tue, Nov 22, 2011 at 11:02:33PM +0100, Corentin Chary wrote: >> Create _init()/_exit() function for each subsystem, remove >> the local struct samsung_laptop * and only keep a >> struct platform_device * that can only be used in samsung_init() >> and samsung_exit(). >> >> Signed-off-by: Corentin Chary <corentincj@iksaif.net> > > It seems a little gratitous, but hey, if you want to maintain this > driver, I have no objection to you rewriting the thing :) > > Acked-by: Greg Kroah-Hartman <gregkh@suse.de>
Well, doing that seems to help with error paths, and make it easy separate functionalities, in my opinion.
-- Corentin Chary http://xf.iksaif.net
| |