lkml.org 
[lkml]   [2011]   [Nov]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 02/15] samsung-laptop: move code into init/exit functions
From
On Tue, Nov 22, 2011 at 11:19 PM, Greg KH <gregkh@suse.de> wrote:
> On Tue, Nov 22, 2011 at 11:02:33PM +0100, Corentin Chary wrote:
>> Create _init()/_exit() function for each subsystem, remove
>> the local struct samsung_laptop * and only keep a
>> struct platform_device * that can only be used in samsung_init()
>> and samsung_exit().
>>
>> Signed-off-by: Corentin Chary <corentincj@iksaif.net>
>
> It seems a little gratitous, but hey, if you want to maintain this
> driver, I have no objection to you rewriting the thing :)
>
> Acked-by: Greg Kroah-Hartman <gregkh@suse.de>

Well, doing that seems to help with error paths, and make it easy
separate functionalities, in my opinion.

--
Corentin Chary
http://xf.iksaif.net


\
 
 \ /
  Last update: 2011-11-23 07:27    [W:0.038 / U:0.896 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site